Re: [PATCH nf-next v2] netfilter: bridge: introduce broute meta statement

[Florian Westphal <fw@xxxxxxxxx>]

Sriram Yagnaraman <sriram.yagnaraman@xxxxxxxx> wrote:
> +static void nft_meta_bridge_set_eval(const struct nft_expr *expr,
> +				     struct nft_regs *regs,
> +				     const struct nft_pktinfo *pkt)
> +{
> +	const struct nft_meta *meta = nft_expr_priv(expr);
> +	struct sk_buff *skb = pkt->skb;
> +	u32 *sreg = &regs->data[meta->sreg];
> +	u8 value8;

Some people insist on

> +	const struct nft_meta *meta = nft_expr_priv(expr);
> +	u32 *sreg = &regs->data[meta->sreg];
> +	struct sk_buff *skb = pkt->skb;

Just saying this for future patches, I don't care, so:

Reviewed-by: Florian Westphal <fw@xxxxxxxxx>