On Sat, Jan 28, 2023 at 06:03:37PM +0200, Vlad Buslov wrote: > > On Sat 28 Jan 2023 at 16:27, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > Hi, > > > > On Fri, Jan 27, 2023 at 07:38:40PM +0100, Vlad Buslov wrote: > >> Currently flow_offload_fixup_ct() function assumes that only replied UDP > >> connections can be offloaded and hardcodes UDP_CT_REPLIED timeout value. > >> Allow users to modify timeout calculation by implementing new flowtable > >> type callback 'timeout' and use the existing algorithm otherwise. > >> > >> To enable UDP NEW connection offload in following patches implement > >> 'timeout' callback in flowtable_ct of act_ct which extracts the actual > >> connections state from ct->status and set the timeout according to it. > > > > I found a way to fix the netfilter flowtable after your original v3 > > update. > > > > Could you use your original patch in v3 for this fixup? > > Sure, please send me the fixup. What I mean is if you could use your original v3 2/7 for this conntrack timeout fixup: https://patchwork.ozlabs.org/project/netfilter-devel/patch/20230119195104.3371966-3-vladbu@xxxxxxxxxx/ I will send a patch for netfilter's flowtable datapath to address the original issue I mentioned, so there is no need for this new timeout callback.
