Re: [PATCH nf-next] netfilter: conntrack: udp: fix seen-reply test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 23/01/2023 14:04, Florian Westphal wrote:
> IPS_SEEN_REPLY_BIT is only useful for test_bit() api.
> 
> Fixes: 4883ec512c17 ("netfilter: conntrack: avoid reload of ct->status")
> Reported-by: Roi Dayan <roid@xxxxxxxxxx>
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> ---
>  net/netfilter/nf_conntrack_proto_udp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nf_conntrack_proto_udp.c b/net/netfilter/nf_conntrack_proto_udp.c
> index 6b9206635b24..0030fbe8885c 100644
> --- a/net/netfilter/nf_conntrack_proto_udp.c
> +++ b/net/netfilter/nf_conntrack_proto_udp.c
> @@ -104,7 +104,7 @@ int nf_conntrack_udp_packet(struct nf_conn *ct,
>  	/* If we've seen traffic both ways, this is some kind of UDP
>  	 * stream. Set Assured.
>  	 */
> -	if (status & IPS_SEEN_REPLY_BIT) {
> +	if (status & IPS_SEEN_REPLY) {
>  		unsigned long extra = timeouts[UDP_CT_UNREPLIED];
>  		bool stream = false;
>  

Reviewed-by: Roi Dayan <roid@xxxxxxxxxx>

thanks



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux