On Fri, Jan 13, 2023 at 06:15:55PM +0200, Vlad Buslov wrote: > On Fri 13 Jan 2023 at 10:12, Simon Horman <simon.horman@xxxxxxxxxxxx> wrote: > > + Baowen Zheng, oss-drivers@xxxxxxxxxxxx ... > > Hi Vlad, > > > > Some feedback from Baowen Zheng, who asked me to pass it on here: > > > > It is confusing that after FLOW_ACTION_CT_METADATA check, this functoin > > will return false, that is -EOPNOTSUPP. > > > > Since this function is only used to check nft table, It seems better to > > change its name to nfp_fl_ct_offload_nft_supported(). This would make things > > clearer and may avoid it being used in the wrong way. > > Thanks for the suggestions! I will change the naming and send V2. Thanks Vlad, much appreciated.