Re: [PATCH ulogd2 2/4] filter: fix buffer sizes in filter plug-ins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-12-08, at 22:07:33 +0100, Pablo Neira Ayuso wrote:
> On Sat, Dec 03, 2022 at 07:02:10PM +0000, Jeremy Sowden wrote:
> [...]
> > The arrays are indexed by subtracting `START_KEY` from the enum
> > value of the key currently being processed: `hwmac_str[okey -
> > START_KEY]`.  However, this means that the last key (`KEY_MAC_ADDR`
> > in this example) will run off the end of the array.  Increase the
> > size of the arrays.
>
> BTW, did you detect this via valgrind or such? If so, posting an
> extract of the splat in the commit message is good to have.

One of the GCC sanitizers, IIRC.  I'll make sure to include a trace in
future.

J.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux