Re: [PATCH nft 2/2,v2] netlink: swap byteorder of value component in concatenation of intervals

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 08, 2022 at 01:40:28AM +0100, Pablo Neira Ayuso wrote:
> Commit 1017d323cafa ("src: support for selectors with different byteorder with
> interval concatenations") was incomplete.
> 
> Switch byteorder of singleton values in a set that contains
> concatenation of intervals. This singleton value is actually represented
> as a range in the kernel.
> 
> After this patch, if the set represents a concatenation of intervals:
> 
> - EXPR_F_INTERVAL denotes the lhs of the interval.
> - EXPR_F_INTERVAL_END denotes the rhs of the interval (this flag was
>   already used in this way before this patch).
> 
> If none of these flags are set on, then the set contains concatenation
> of singleton values (no interval flag is set on), in such case, no
> byteorder swap is required.
> 
> Update tests/shell and tests/py to cover the use-case breakage reported
> by Eric.
> 
> Reported-by: Eric Garver <eric@xxxxxxxxxxx>
> Fixes: 1017d323cafa ("src: support for selectors with different byteorder with interval concatenations")
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> ---

Thanks Pablo!

Tested-by: Eric Garver <eric@xxxxxxxxxxx>




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux