On Tue, Nov 29, 2022 at 09:47:15PM +0000, Jeremy Sowden wrote: > In his feedback to my last series of clean-up patches at the beginning > of the year, Pablo suggested consolidating some parallel implementations > of the same functionality in the SQL output plug-ins. I already had > some patches in the works aimed at tidying up the DB API. This > patch-set is the result. In addition to the suggested de-duping and > other tidy-ups, I have added prep & exec support in order to convert the > sqlite3 plug-in to the DB API, and updated the MySQL and PostgreSQL > plug-ins to use it as well (DBI doesn't do prep & exec). > > This patch-set is structured as follows. > > * Patches 1-4 are bug-fixes. > * Patches 5-13 are miscellaneous tidying. > * Patch 14 does the consolidation Pablo suggested. > * Patches 15-26 refactor and clean up the common DB API. > * Patches 27-28 add prep & exec support to the common DB API. > * Patch 29 converts the MySQL plug-in to use prep & exec. > * Patch 30-33 tidy up and convert the PostgreSQL plug-in to use prep & > exec. > * Patch 34 converts the SQLite plug-in to use the common DB API. It's great that ulogd2 is getting updates, thanks a lot. But would it be possible to start with a smaller batch? We review integrate and then you follow up with more updates. I'll aim at being swift on it. I'd suggest 10-15 patches in each round.
