This is a review of all extensions' xlate callbacks focussing on correctness of operation and return code. Patches 1 and 2 address ebtables mark target. Patches 3, 4, 6 and 9 add 'return 0' calls in more or less unlikely cases. Patch 5 fixes multiple problems in CONNMARK target. Patches 7, 8 and 10 extend some translations. The last three patches add comments to help future reviewers asserting code correctness. Phil Sutter (13): extensions: libebt_mark: Fix mark target xlate extensions: libebt_mark: Fix xlate test case extensions: libebt_redirect: Fix xlate return code extensions: libipt_ttl: Sanitize xlate callback extensions: CONNMARK: Fix xlate callback extensions: MARK: Sanitize MARK_xlate() extensions: TCPMSS: Use xlate callback for IPv6, too extensions: TOS: Fix v1 xlate callback extensions: ecn: Sanitize xlate callback extensions: tcp: Translate TCP option match extensions: libebt_log: Add comment to clarify xlate callback extensions: frag: Add comment to clarify xlate callback extensions: ipcomp: Add comment to clarify xlate callback extensions/libebt_log.c | 2 ++ extensions/libebt_mark.c | 2 +- extensions/libebt_mark.txlate | 11 +++++++++++ extensions/libebt_mark.xlate | 11 ----------- extensions/libebt_redirect.c | 2 +- extensions/libip6t_frag.c | 2 ++ extensions/libipt_ttl.c | 4 ++-- extensions/libxt_CONNMARK.c | 15 ++++++++++----- extensions/libxt_CONNMARK.txlate | 3 +++ extensions/libxt_MARK.c | 2 ++ extensions/libxt_TCPMSS.c | 1 + extensions/libxt_TOS.c | 33 ++++++++++++++++++++++---------- extensions/libxt_TOS.txlate | 9 ++++++--- extensions/libxt_ecn.c | 2 ++ extensions/libxt_ipcomp.c | 2 ++ extensions/libxt_ipcomp.c.man | 3 --- extensions/libxt_tcp.c | 9 ++++++--- extensions/libxt_tcp.txlate | 6 ++++++ 18 files changed, 80 insertions(+), 39 deletions(-) create mode 100644 extensions/libebt_mark.txlate delete mode 100644 extensions/libebt_mark.xlate -- 2.38.0
