Hi, On Wed, 28 Sep 2022, Vishwanath Pai wrote: > Add a new parameter to complement the existing 'netmask' option. The > main difference between netmask and bitmask is that bitmask takes any > arbitrary ip address as input, it does not have to be a valid netmask. > > The name of the new parameter is 'bitmask'. This lets us mask out > arbitrary bits in the ip address, for example: > ipset create set1 hash:ip bitmask 255.128.255.0 > ipset create set2 hash:ip,port family inet6 bitmask ffff::ff80 > > This patchset contains userspace patches, I will submit the kernel patch > separately. > > Changes in v2 based on code review comments: > * Removed the changes to nf_inet_addr.h and nfproto.h, this will break on older kernels > * Remove bitmask option from net,net since it is redundant, update the manpage > * Add tests for the new bitmask param (similar to netmask tests) Thanks for the patch, it's much better. I have a few comments only and will send them separatedly at the given patches. All other parts are OK. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxx PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics H-1525 Budapest 114, POB. 49, Hungary
