Re: [PATCH nf-next v2] netfilter: nf_tables: add support to destroy operation

[Fernando Fernandez Mancera <ffmancera@xxxxxxxxxx>]

Hi,

On 28/10/2022 20:27, Phil Sutter wrote:
> Hi,
>
> On Fri, Oct 28, 2022 at 12:05:31PM +0200, Fernando Fernandez Mancera wrote:
> [...]
> > @@ -3636,6 +3642,9 @@ static int nf_tables_delrule(struct sk_buff *skb, const struct nfnl_info *info,
> >   		if (nla[NFTA_RULE_HANDLE]) {
> >   			rule = nft_rule_lookup(chain, nla[NFTA_RULE_HANDLE]);
> >   			if (IS_ERR(rule)) {
> > +				if (PTR_ERR(rule) == -ENOENT &&
> > +				    NFNL_MSG_TYPE(info->nlh->nlmsg_type) == NFT_MSG_DESTROYRULE)
> > +					return 0;
> >   				NL_SET_BAD_ATTR(extack, nla[NFTA_RULE_HANDLE]);
> >   				return PTR_ERR(rule);
> >   			}
>
> I guess you're exceeding the 80 column limit here? Doesn't checkpatch.pl
> complain?

Nope, checkpatch.pl checks for a 100 column limit. Anyway, let me send a 
v3 as I prefer the 80 column limit.

Thanks,
Fernando.

> Cheers, Phil