Jeremy Sowden <jeremy@xxxxxxxxxx> wrote: > > __interceptor_malloc libsanitizer/asan/asan_malloc_linux.cpp:145 > > xmalloc src/utils.c:36 > > xzalloc src/utils.c:75 > > expr_alloc src/expression.c:46 > > constant_expr_alloc src/expression.c:420 > > interval_map_decompose src/segtree.c:619 > > I did try running the new shell test under valgrind: lots of noise, not > a lot of signal. :) Yes. You can use -fsanitize=leak as alternative, that has a much better signal/noise ratio. > > Before, 'i' was assigned to the compund expr, but thats no longer the > > case. > > > Does this look good to you? > > Yes, LTGM. Applied, thanks!
