Re: [PATCH nft] evaluate: un-break rule insert with intervals

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 20, 2022 at 02:57:26PM +0200, Florian Westphal wrote:
> 'rule inet dscpclassify dscp_match  meta l4proto { udp }  th dport { 3478 }  th sport { 3478-3497, 16384-16387 } goto ct_set_ef'
> works with 'nft add', but not 'nft insert', the latter yields: "BUG: unhandled op 4".

That's my fault, thanks for the fix.

Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

P.S: Please add a simple test for this regression.

> Fixes: 81e36530fcac ("src: replace interval segment tree overlap and automerge")
> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> ---
>  src/evaluate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/evaluate.c b/src/evaluate.c
> index d9c9ca28a53a..edebd7bcd8ab 100644
> --- a/src/evaluate.c
> +++ b/src/evaluate.c
> @@ -1520,6 +1520,7 @@ static int interval_set_eval(struct eval_ctx *ctx, struct set *set,
>  	switch (ctx->cmd->op) {
>  	case CMD_CREATE:
>  	case CMD_ADD:
> +	case CMD_INSERT:
>  		if (set->automerge) {
>  			ret = set_automerge(ctx->msgs, ctx->cmd, set, init,
>  					    ctx->nft->debug_mask);
> -- 
> 2.35.1
> 



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux