Re: [PATCH nft] src: allow burst 0 for byte ratelimit and use it as default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 30, 2022 at 05:37:46PM +0200, Pablo Neira Ayuso wrote:
> Packet-based limit burst is set to 5, as in iptables. However,
> byte-based limit burst adds to the rate to calculate the bucket size,
> and this is also sets this to 5 (... bytes in this case). Update it to
> use zero byte burst by default instead.
> 
> This patch also updates manpage to describe how the burst value
> influences the kernel module's token bucket in each of the two modes.
> This documentation update is based on original text by Phil Sutter.
> 
> Adjust tests/py to silence warnings due to mismatching byte burst.
> 
> Fixes: 285baccfea46 ("src: disallow burst 0 in ratelimits")
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Acked-by: Phil Sutter <phil@xxxxxx>

Thanks for taking over the man page adjustment!



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux