Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/netfilter-remove-NFPROTO_DECNET/20220822-224303 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: mips-randconfig-r014-20220822 (https://download.01.org/0day-ci/archive/20220823/202208231725.M6uhYNZi-lkp@xxxxxxxxx/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project b04d01c009d7f66bcca9138d2ce40999eedf104d) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/0776a7974c60171c4c1322add934ecc73273f538 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Florian-Westphal/netfilter-remove-NFPROTO_DECNET/20220822-224303 git checkout 0776a7974c60171c4c1322add934ecc73273f538 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash net/decnet/ net/netfilter/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from net/decnet/af_decnet.c:109: include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? case NFPROTO_DECNET: ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ In file included from net/decnet/af_decnet.c:111: In file included from include/net/sock.h:60: >> include/linux/poll.h:140:27: warning: division by zero is undefined [-Wdivision-by-zero] M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | ^~~~~~~~~ include/linux/poll.h:138:32: note: expanded from macro 'M' #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/poll.h:124:51: note: expanded from macro '__MAP' (from < to ? (v & from) * (to/from) : (v & from) / (from/to)) ^ ~~~~~~~~~ include/linux/poll.h:140:39: warning: division by zero is undefined [-Wdivision-by-zero] M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | ^~~~~~~~~ include/linux/poll.h:138:32: note: expanded from macro 'M' #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/poll.h:124:51: note: expanded from macro '__MAP' (from < to ? (v & from) * (to/from) : (v & from) / (from/to)) ^ ~~~~~~~~~ 2 warnings and 1 error generated. -- In file included from net/decnet/dn_neigh.c:37: In file included from include/uapi/linux/netfilter_decnet.h:11: include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? case NFPROTO_DECNET: ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ In file included from net/decnet/dn_neigh.c:47: In file included from include/net/dn.h:6: In file included from include/net/sock.h:60: >> include/linux/poll.h:140:27: warning: division by zero is undefined [-Wdivision-by-zero] M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | ^~~~~~~~~ include/linux/poll.h:138:32: note: expanded from macro 'M' #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/poll.h:124:51: note: expanded from macro '__MAP' (from < to ? (v & from) * (to/from) : (v & from) / (from/to)) ^ ~~~~~~~~~ include/linux/poll.h:140:39: warning: division by zero is undefined [-Wdivision-by-zero] M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | ^~~~~~~~~ include/linux/poll.h:138:32: note: expanded from macro 'M' #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/poll.h:124:51: note: expanded from macro '__MAP' (from < to ? (v & from) * (to/from) : (v & from) / (from/to)) ^ ~~~~~~~~~ net/decnet/dn_neigh.c:250:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? return NF_HOOK(NFPROTO_DECNET, NF_DN_POST_ROUTING, ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ net/decnet/dn_neigh.c:291:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? return NF_HOOK(NFPROTO_DECNET, NF_DN_POST_ROUTING, ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ net/decnet/dn_neigh.c:333:17: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? return NF_HOOK(NFPROTO_DECNET, NF_DN_POST_ROUTING, ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ 2 warnings and 4 errors generated. -- In file included from net/netfilter/core.c:10: include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? case NFPROTO_DECNET: ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ In file included from net/netfilter/core.c:19: In file included from include/linux/netfilter_ipv6.h:11: In file included from include/net/tcp.h:20: In file included from include/linux/tcp.h:19: In file included from include/net/sock.h:60: >> include/linux/poll.h:140:27: warning: division by zero is undefined [-Wdivision-by-zero] M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | ^~~~~~~~~ include/linux/poll.h:138:32: note: expanded from macro 'M' #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/poll.h:124:51: note: expanded from macro '__MAP' (from < to ? (v & from) * (to/from) : (v & from) / (from/to)) ^ ~~~~~~~~~ include/linux/poll.h:140:39: warning: division by zero is undefined [-Wdivision-by-zero] M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | ^~~~~~~~~ include/linux/poll.h:138:32: note: expanded from macro 'M' #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/poll.h:124:51: note: expanded from macro '__MAP' (from < to ? (v & from) * (to/from) : (v & from) / (from/to)) ^ ~~~~~~~~~ net/netfilter/core.c:304:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? case NFPROTO_DECNET: ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ 2 warnings and 2 errors generated. -- In file included from net/decnet/netfilter/dn_rtmsg.c:18: include/linux/netfilter.h:247:7: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? case NFPROTO_DECNET: ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ In file included from net/decnet/netfilter/dn_rtmsg.c:23: In file included from include/net/sock.h:60: >> include/linux/poll.h:140:27: warning: division by zero is undefined [-Wdivision-by-zero] M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | ^~~~~~~~~ include/linux/poll.h:138:32: note: expanded from macro 'M' #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/poll.h:124:51: note: expanded from macro '__MAP' (from < to ? (v & from) * (to/from) : (v & from) / (from/to)) ^ ~~~~~~~~~ include/linux/poll.h:140:39: warning: division by zero is undefined [-Wdivision-by-zero] M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | ^~~~~~~~~ include/linux/poll.h:138:32: note: expanded from macro 'M' #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/poll.h:124:51: note: expanded from macro '__MAP' (from < to ? (v & from) * (to/from) : (v & from) / (from/to)) ^ ~~~~~~~~~ net/decnet/netfilter/dn_rtmsg.c:118:9: error: use of undeclared identifier 'NFPROTO_DECNET'; did you mean 'NFPROTO_INET'? .pf = NFPROTO_DECNET, ^~~~~~~~~~~~~~ NFPROTO_INET include/uapi/linux/netfilter.h:60:2: note: 'NFPROTO_INET' declared here NFPROTO_INET = 1, ^ 2 warnings and 2 errors generated. vim +140 include/linux/poll.h 7a163b2195cda0 Al Viro 2018-02-01 135 7a163b2195cda0 Al Viro 2018-02-01 136 static inline __poll_t demangle_poll(u16 val) 7a163b2195cda0 Al Viro 2018-02-01 137 { 7a163b2195cda0 Al Viro 2018-02-01 138 #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X) 7a163b2195cda0 Al Viro 2018-02-01 139 return M(IN) | M(OUT) | M(PRI) | M(ERR) | M(NVAL) | 7a163b2195cda0 Al Viro 2018-02-01 @140 M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) | 7a163b2195cda0 Al Viro 2018-02-01 141 M(HUP) | M(RDHUP) | M(MSG); 7a163b2195cda0 Al Viro 2018-02-01 142 #undef M 7a163b2195cda0 Al Viro 2018-02-01 143 } 7a163b2195cda0 Al Viro 2018-02-01 144 #undef __MAP 7a163b2195cda0 Al Viro 2018-02-01 145 7a163b2195cda0 Al Viro 2018-02-01 146 -- 0-DAY CI Kernel Test Service https://01.org/lkp
