On Mon, Aug 15, 2022 at 3:40 PM Florian Westphal <fw@xxxxxxxxx> wrote: > > Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote: > > > Support direct writes to nf_conn:mark from TC and XDP prog types. This > > > is useful when applications want to store per-connection metadata. This > > > is also particularly useful for applications that run both bpf and > > > iptables/nftables because the latter can trivially access this metadata. > > > > > > One example use case would be if a bpf prog is responsible for advanced > > > packet classification and iptables/nftables is later used for routing > > > due to pre-existing/legacy code. > > > > > > Signed-off-by: Daniel Xu <dxu@xxxxxxxxx> > > > > Didn't we agree the last time around that all field access should be > > using helper kfuncs instead of allowing direct writes to struct nf_conn? > > I don't see why ct->mark needs special handling. > > It might be possible we need to change accesses on nf/tc side to use > READ/WRITE_ONCE though. +1 I don't think we need to have a hard rule. If fields is safe to access directly than it's faster to let bpf prog read/write it. There are no backward compat concerns. If conntrack side decides to make that field special we can disallow direct writes in the same kernel version. These accesses, just like kfuncs, are unstable.
