Re: [PATCH libmnl] build: doc: refer to bash as bash, not /bin/bash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mark,

On Mon, Aug 01, 2022 at 01:26:20PM -0400, Mark Mentovai wrote:
> This locates bash according to its presence in the PATH, not at a
> hard-coded path which may not exist or may not be the most suitable bash
> to use.
>
> Signed-off-by: Mark Mentovai <mark@xxxxxxxxxxxx>
> ---
>  doxygen/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doxygen/Makefile.am b/doxygen/Makefile.am
> index 29078dee122a..189a233f3760 100644
> --- a/doxygen/Makefile.am
> +++ b/doxygen/Makefile.am
> @@ -21,7 +21,7 @@ doxyfile.stamp: $(doc_srcs) Makefile.am
>  # The command has to be a single line so the functions work
>  # and so `make` gives all lines to `bash -c`
>  # (hence ";\" at the end of every line but the last).
> -	/bin/bash -p -c 'declare -A renamed_page;\
> +	bash -p -c 'declare -A renamed_page;\
>  main(){ set -e; cd man/man3; rm -f _*;\
>    count_real_pages;\
>    rename_real_pages;\
> --
> 2.37.1
>
I would not apply this patch unless it's actually necessary for some
distribution.

If you have discovered a distribution where /bin/bash doesn't work, please let
us know.

Scripts that start "#!/bin/bash" are not uncommon, and Netfilter already has a
couple of these, in libnetfilter_queue and libnetfilter_log.

I somehow omitted to update libmnl to replace the cumbersome embedded script in
Makefile.am with a stand-alone script, but you've reminded me.

Cheers ... Duncan.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux