On Wed, 13 Jul 2022, Vishwanath Pai wrote:
> On 7/12/22 17:06, Jozsef Kadlecsik wrote:
> >
> > On Wed, 29 Jun 2022, Vishwanath Pai wrote:
> >
> >> We fixed a similar problem before in commit 7f4f7dd4417d ("netfilter:
> >> ipset: ipset list may return wrong member count for set with timeout").
> >> The same issue exists in ip_set_bitmap_gen.h as well.
> >
> > Could you rework the patch to solve the issue the same way as for the hash
> > types (i.e. scanning the set without locking) like in the commit
> > 33f08da28324 (netfilter: ipset: Fix "INFO: rcu detected stall in hash_xxx"
> > reports)? I know the bitmap types have got a limited size but it'd be
> > great if the general method would be the same across the different types.
>
> Sure, I'll give it a try. It might take me a bit longer cause it looks like a
> complex set of changes.
I meant not the whole commit 33f08da28324, of course there is no need for
region locking at the bitmap types. Just to count non-expired elements
(and extension size) so that it's a reader function and doesn't need
locking.
Best regards,
Jozsef
-
E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxx
PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
H-1525 Budapest 114, POB. 49, Hungary
