Will Deacon <will@xxxxxxxxxx> wrote: > On Wed, Jul 06, 2022 at 02:02:01PM +0200, Florian Westphal wrote: > > + /* ->status and ->timeout loads must happen after refcount increase */ > > + smp_rmb(); > > Sorry I didn't suggest this earlier, but if all of these smp_rmb()s are > for upgrading the ordering from refcount_inc_not_zero() then you should > use smp_acquire__after_ctrl_dep() instead. It's the same under the hood, > but it illustrates what's going on a bit better. Ok, I can replace it and send a v2, no problem.