On Sat, Jul 02, 2022 at 12:39:28AM +0200, Stefano Brivio wrote: [...] > Other than that, it looks good to me. > > I would also specify in the commit message that we additionally look > for elements pointers in the cloned matching data if priv->dirty is > set, because that means that cloned data might point to additional > elements we didn't commit to the working copy yet (such as the abort > path case, but perhaps not limited to it). This v2, I forgot to tag it properly: https://patchwork.ozlabs.org/project/netfilter-devel/patch/20220702021631.796822-2-pablo@xxxxxxxxxxxxx/ it is updating documentation and it also adds a paragraph to the commit description as you suggested.