Re: [PATCH nft] tests: shell: large set overlap and automerge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 23, 2022 at 06:14:17PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Jun 23, 2022 at 05:59:52PM +0200, Phil Sutter wrote:
> > On Thu, Jun 16, 2022 at 11:35:41AM +0200, Pablo Neira Ayuso wrote:
> > > Add a test to validate set overlap and automerge for large set. This
> > > test runs nft -f twice to cover for set reload without flush.
> > 
> > I had this in mind as well, but didn't like to hard-code any thresholds.
> > Your test is useful only for manual result review and will always pass,
> > therefore will only increase testsuite run time without any benefit.
> 
> Yes, I run them manually often and it won't work for a robot, unless
> time is printed somewhere and the robot identifies an anomaly there.
> 
> I can remove it if you like.

Just don't push it? :)



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux