On Thu, Jun 23, 2022 at 05:42:30PM +0200, Pablo Neira Ayuso wrote: > On Thu, Jun 23, 2022 at 05:41:46PM +0200, Pablo Neira Ayuso wrote: > > On Thu, Jun 23, 2022 at 04:28:43PM +0200, Phil Sutter wrote: > > > This reverts commit df4ee3171f3e3c0e85dd45d555d7d06e8c1647c5 as it > > > breaks ipsec expression if preceeded by a counter statement: > > > > > > | Error: syntax error, unexpected string, expecting saddr or daddr > > > | add rule ip ipsec-ip4 ipsec-forw counter ipsec out ip daddr 192.168.1.2 > > > | ^^^^^ > > > > Please add a test covering this regression case. > > Oh, actually coming in a separated patch. Probably collapsing them is > better for git annotate, but your call. ACK, will send a v2.