On Wed, Jun 22, 2022 at 12:27:05PM +0200, Mikhail Sennikovsky wrote: > Hi Pablo, > > I initially decided against it because Introducing a separate CT_ADD > command would > result in lots of actually unnecessary changes in lots of places, e.g. > the optset arrays definitions (passed to generic_opt_check) in > conntrac.c and all extensions would need a new (actually duplicate) > entry for the CT_ADD, e.g. here > https://git.netfilter.org/conntrack-tools/tree/extensions/libct_proto_dccp.c#n67 > But if you prefer this approach, I can surely do that. Let me adjust & > submit an updated patch then. That's basically: - update commands_v_options - update cmd2type - update exit_msg - update err2str - add extra CT_ADD case in switch. - add CT_ADD as a valid command for batch mode That should be fine, I prefer if -A fully qualifies as a command, not as a flag.
