Sure, let me remove it then and submit an updated patch here. Thanks, Mikhail On Thu, 9 Jun 2022 at 12:20, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > Hi, > > On Wed, Jun 08, 2022 at 04:16:34PM +0200, Mikhail Sennikovsky wrote: > > Hi Pablo, > > > > Then I misunderstood you, my bad. > > Yes, _check is never used for events, and the socket->events is not > > used anywhere except the assert(events == socket->events); assertion > > check which I found useful as a sanity check for potential future uses > > of the nfct_mnl_socket_check_open. > > If you find it unneeded however, I'm fine with removing it. > > If not used now for this usecase, I'd prefer if you remove it.