Hi Pablo, I love your patch! Perhaps something to improve: [auto build test WARNING on nf/master] url: https://github.com/intel-lab-lkp/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_tables-disallow-non-stateful-expression-in-sets-earlier/20220526-190122 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220526/202205262104.cowfvBMc-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6f4644d194da594562027a5d458d9fb7a20ebc39) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/08b6b97fd372a14e82e821bb2b4c9c10c1426080 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-nf_tables-disallow-non-stateful-expression-in-sets-earlier/20220526-190122 git checkout 08b6b97fd372a14e82e821bb2b4c9c10c1426080 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/netfilter/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> net/netfilter/nf_tables_api.c:5431:17: warning: variable 'err' is uninitialized when used here [-Wuninitialized] return ERR_PTR(err); ^~~ net/netfilter/nf_tables_api.c:5413:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 1 warning generated. vim +/err +5431 net/netfilter/nf_tables_api.c 60319eb1ca351a Pablo Neira Ayuso 2014-04-04 5407 a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5408 struct nft_expr *nft_set_elem_expr_alloc(const struct nft_ctx *ctx, a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5409 const struct nft_set *set, a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5410 const struct nlattr *attr) a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5411 { a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5412 struct nft_expr *expr; a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5413 int err; a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5414 a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5415 expr = nft_expr_init(ctx, attr); a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5416 if (IS_ERR(expr)) a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5417 return expr; a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5418 a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5419 if (expr->ops->type->flags & NFT_EXPR_GC) { a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5420 if (set->flags & NFT_SET_TIMEOUT) a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5421 goto err_set_elem_expr; a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5422 if (!set->ops->gc_init) a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5423 goto err_set_elem_expr; a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5424 set->ops->gc_init(set); a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5425 } a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5426 a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5427 return expr; a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5428 a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5429 err_set_elem_expr: a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5430 nft_expr_destroy(ctx, expr); a7fc9368040841 Pablo Neira Ayuso 2020-03-11 @5431 return ERR_PTR(err); a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5432 } a7fc9368040841 Pablo Neira Ayuso 2020-03-11 5433 -- 0-DAY CI Kernel Test Service https://01.org/lkp
