On Tue, 15 Mar 2022 21:10:33 +0100 Pablo Neira Ayuso wrote: > > > return (IS_ENABLED(CONFIG_NF_TABLES_INET) && family == NFPROTO_INET)) || > > > (IS_ENABLED(CONFIG_NF_TABLES_IPV4) && family == NFPROTO_IPV4)) || > > > ... > > > > > > would have also been an option, for future reference. > > > > Yes, that is indeed much cleaner. I wasn't aware of this possibility > > using IS_ENABLED. What do you think, worth a follow-up? > > CONFIG_NF_TABLES_INET and CONFIG_NF_TABLES_IPV4 are never modules, I > think IS_ENABLED is misleading there to the reader. It's not about being a module, IS_ENABLED() is usable in C code, no need to use the pre-processor. But your call, obviously.