Re: [PATCH v3] netfilter: nf_tables: fix memory leak during stateful obj update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 21, 2022 at 01:31:49PM +0100, Florian Westphal wrote:
> stateful objects can be updated from the control plane.
> The transaction logic allocates a temporary object for this purpose.
> 
> The ->init function was called for this object, so plain kfree() leaks
> resources. We must call ->destroy function of the object.
> 
> nft_obj_destroy does this, but it also decrements the module refcount,
> but the update path doesn't increment it.
> 
> To avoid special-casing the update object release, do module_get for
> the update case too and release it via nft_obj_destroy().

Also applied, thanks



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux