Re: [PATCH net 1/1] net/sched: act_ct: Fix flow table lookup failure with no originating ifindex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 17, 2022 at 11:34:24AM +0200, Paul Blakey wrote:
> After cited commit optimizted hw insertion, flow table entries are
> populated with ifindex information which was intended to only be used
> for HW offload. This tuple ifindex is hashed in the flow table key, so
> it must be filled for lookup to be successful. But tuple ifindex is only
> relevant for the netfilter flowtables (nft), so it's not filled in
> act_ct flow table lookup, resulting in lookup failure, and no SW
> offload and no offload teardown for TCP connection FIN/RST packets.
> 
> To fix this, allow flow tables that don't hash the ifindex.
> Netfilter flow tables will keep using ifindex for a more specific
> offload, while act_ct will not.
> 
> Fixes: 9795ded7f924 ("net/sched: act_ct: Fill offloading tupledx")

The fixes tag got corrupted. It should have been:
Fixes: 9795ded7f924 ("net/sched: act_ct: Fill offloading tuple iifidx")

Not sure if it needs a respin or not, but:
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@xxxxxxxxx>

> Signed-off-by: Paul Blakey <paulb@xxxxxxxxxx>
> ---



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux