On Fri, Feb 11, 2022 at 12:29 AM Eric Dumazet <edumazet@xxxxxxxxxx> wrote: > > On Thu, Feb 10, 2022 at 8:13 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > > > On Thu, 10 Feb 2022 21:42:14 +0800 Menglong Dong wrote: > > > How about introducing a field to 'struct sock' for drop reasons? As sk is > > > locked during the packet process in tcp_v4_do_rcv(), this seems to work. > > > > I find adding temporary storage to persistent data structures awkward. > > You can put a structure on the stack and pass it thru the call chain, > > that's just my subjective preference, tho, others may have better ideas. > > I had a similar TODO item, because stuff like 'waking up task' or free > one skb (or list of skb) could be performed outside of socket lock. May I ask what it's like? Is it used to solve this kind of problem? Thanks! Menglong Dong
