Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx> wrote: > On Tue, Jan 18, 2022 at 02:11:43AM +0100, Pablo Neira Ayuso wrote: > > > > This patch have a number of showstoppers such as exposing structure > > layout on the header files. > > > That's only in patch 5. You could apply 1-4. There are actually no other > showstoppers, right? Regarding patch 5, I think its ok except the pkt_buff layout freeze. >From a quick glance, there is no assumption that the data area resides after the pktbuff head, so it should be possible to keep pkt_buff private, allocate an empty packet and then associate a new buffer with it. I agree the memcpy needs to go, nfqueue uses should use F_GSO feature flag and memcpy'ing 60k big packets isn't ideal.
