Re: [PATCH iptables v2 0/8] extensions: libxt_NFLOG: use nft back-end for iptables-nft

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021-10-01, at 18:41:34 +0100, Jeremy Sowden wrote:
> nftables supports 128-character prefixes for nflog whereas legacy
> iptables only supports 64 characters.  This patch series converts
> iptables-nft to use the nft back-end in order to take advantage of the
> longer prefixes.
>
>   * Patches 1-5 implement the conversion and update some related Python
>     unit-tests.
>   * Patch 6 fixes an minor bug in the output of nflog prefixes.
>   * Patch 7 contains a couple of libtool updates.
>   * Patch 8 fixes some typo's.

I note that Florian merged the first patch in this series recently.
Feedback on the rest of it would be much appreciated.

J.

> Changes since v1:
>
>   * Patches 1 and 5-8 are new.
>   * White-space fixes in patches 2 and 3.
>   * Fixes for typo's in commit-messages of patches 2 and 4.
>   * Removal of stray `struct xt_nflog_info` allocation from
>     `nft_parse_log` in patch 3.
>   * Leave commented-out `--nflog-range` test-cases in libxt_NFLOG.t
>     with an explanatory comment in patch 4.
>
> Jeremy Sowden (5):
>   nft: fix indentation error.
>   extensions: libxt_NFLOG: fix `--nflog-prefix` Python test-cases
>   extensions: libxt_NFLOG: remove extra space when saving targets with
>     prefixes
>   build: replace `AM_PROG_LIBTOOL` and `AC_DISABLE_STATIC` with
>     `LT_INIT`
>   tests: iptables-test: correct misspelt variable
>
> Kyle Bowman (3):
>   extensions: libxt_NFLOG: use nft built-in logging instead of xt_NFLOG
>   extensions: libxt_NFLOG: don't truncate log prefix on print/save
>   extensions: libxt_NFLOG: disable `--nflog-range` Python test-cases
>
>  configure.ac             |  3 +-
>  extensions/libxt_NFLOG.c |  8 ++++-
>  extensions/libxt_NFLOG.t | 16 ++++-----
>  iptables-test.py         | 18 +++++-----
>  iptables/nft-shared.c    | 52 ++++++++++++++++++++++++++++
>  iptables/nft.c           | 74 ++++++++++++++++++++++++++++------------
>  iptables/nft.h           |  1 +
>  7 files changed, 131 insertions(+), 41 deletions(-)
>
> --
> 2.33.0
>
>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux