On Mon, Jan 10, 2022 at 10:29:37PM +0100, Pablo Neira Ayuso wrote:
> On Fri, Dec 24, 2021 at 06:17:49PM +0100, Phil Sutter wrote:
> [...]
> > diff --git a/iptables/xshared.h b/iptables/xshared.h
> > index dde94b7335f6a..1954168f64058 100644
> > --- a/iptables/xshared.h
> > +++ b/iptables/xshared.h
> [...]
> > struct xt_cmd_parse {
> > unsigned int command;
> > unsigned int rulenum;
> > @@ -272,6 +305,11 @@ struct xt_cmd_parse {
> > bool restore;
> > int verbose;
> > bool xlate;
>
> Probably wrap these two common functions between legacy and nft in a
> structure? Something like: struct nft_parse_ops...
Ah yes, thanks for suggesting. Wrapping the callbacks didn't come to
mind despite the need for two assignments everywhere.
I'll fix and resubmit.
Cheers, Phil
