Re: [PATCH net-next] netfilter: nf_tables: fix compile warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 10 Jan 2022 23:14:19 +0100 Pablo Neira Ayuso wrote:
> Remove unused variable and fix missing initialization.
> 
> >> net/netfilter/nf_tables_api.c:8266:6: warning: variable 'i' set but not used [-Wunused-but-set-variable]  
>            int i;
>                ^
> >> net/netfilter/nf_tables_api.c:8277:4: warning: variable 'data_size' is uninitialized when used here [-Wuninitialized]  
>                            data_size += sizeof(*prule) + rule->dlen;
>                            ^~~~~~~~~
>    net/netfilter/nf_tables_api.c:8262:30: note: initialize the variable 'data_size' to silence this warning
>            unsigned int size, data_size;
> 
> Fixes: 2c865a8a28a1 ("netfilter: nf_tables: add rule blob layout")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> ---
> Please, directly apply to net-next, thanks. Otherwise let me know and
> I'll prepare a pull request with pending fixes once net-next gets merged
> into net.

As you have probably seen Linus fixed this up himself.

You can take the fix for the other warning thru your tree.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux