Re: [PATCH v3] netfilter: fix regression in looped (broad|multi)cast's MAC handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 10, 2021 at 04:31:27PM +0100, Ignacy Gawędzki wrote:
> In commit 5648b5e1169f ("netfilter: nfnetlink_queue: fix OOB when mac
> header was cleared"), the test for non-empty MAC header introduced in
> commit 2c38de4c1f8da7 ("netfilter: fix looped (broad|multi)cast's MAC
> handling") has been replaced with a test for a set MAC header.
> 
> This breaks the case when the MAC header has been reset (using
> skb_reset_mac_header), as is the case with looped-back multicast
> packets.  As a result, the packets ending up in NFQUEUE get a bogus
> hwaddr interpreted from the first bytes of the IP header.
> 
> This patch adds a test for a non-empty MAC header in addition to the
> test for a set MAC header.  The same two tests are also implemented in
> nfnetlink_log.c, where the initial code of commit 2c38de4c1f8da7
> ("netfilter: fix looped (broad|multi)cast's MAC handling") has not been
> touched, but where supposedly the same situation may happen.

Applied to nf, thanks



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux