This patch-set fixes all the warnings reported by gcc 11. Most of the warnings concern fall-throughs in switches, possibly problematic uses of functions like `strncpy` and `strncat` and possible truncation of output by `sprintf` and its siblings. Some of the patches fix bugs revealed by warnings, some tweak code to avoid warnings, others fix or improve things I noticed while looking at the warnings. Changes since v2: * the first four patches of v2 have been merged; * some of the v2 patches have been broken up into more, smaller parts; * more detailed commit messages; * patches 14 and 17 are new. Changes since v1: * patch 13: stat of socket removed; * patch 15: `struct iphdr` pointer removed; * patch 27 is new. Jeremy Sowden (32): jhash: add "fall through" comments to switch cases db: add missing `break` to switch case filter: HWHDR: simplify flow-control filter: HWHDR: re-order KEY_RAW_MAC checks filter: HWHDR: remove zero-initialization of MAC type Replace malloc+memset with calloc filter: PWSNIFF: replace malloc+strncpy with strndup input: UNIXSOCK: remove stat of socket-path input: UNIXSOCK: fix possible truncation of socket path input: UNIXSOCK: prevent unaligned pointer access output: DBI: fix deprecation warnings output: DBI: improve mapping of DB columns to input-keys output: DBI: fix NUL-termination of escaped SQL string output: DBI: fix configuration of DB connection output: MYSQL: improve mapping of DB columns to input-keys output: PGSQL: improve mapping of DB columns to input-keys output: PGSQL: fix non-`connstring` configuration of DB connection output: SQLITE3: fix possible buffer overruns output: SQLITE3: fix memory-leak in error-handling output: SQLITE3: improve formatting of insert statement output: SQLITE3: improve mapping of DB columns to fields output: SQLITE3: improve mapping of fields to DB columns output: SQLITE3: catch errors creating SQL statement db: improve formatting of insert statement db: improve mapping of input-keys to DB columns db: simplify initialization of ring-buffer output: JSON: fix output of GMT offset output: JSON: increase time-stamp buffer size output: JSON: fix possible leak in error-handling. output: JSON: optimize appending of newline to output output: JSON: fix possible truncation of socket path output: IPFIX: remove compiler attribute macros filter/ulogd_filter_HWHDR.c | 54 ++++++++--------- filter/ulogd_filter_PWSNIFF.c | 18 +++--- include/ulogd/jhash.h | 24 ++++---- include/ulogd/ulogd.h | 5 -- input/packet/ulogd_inppkt_UNIXSOCK.c | 46 +++++++-------- output/dbi/ulogd_output_DBI.c | 84 +++++++++++++-------------- output/ipfix/ipfix.c | 6 +- output/ipfix/ipfix.h | 8 +-- output/mysql/ulogd_output_MYSQL.c | 20 +++---- output/pgsql/ulogd_output_PGSQL.c | 64 ++++++++------------ output/sqlite3/ulogd_output_SQLITE3.c | 71 +++++++++++----------- output/ulogd_output_JSON.c | 45 +++++++------- src/ulogd.c | 3 +- util/db.c | 36 ++++++------ 14 files changed, 223 insertions(+), 261 deletions(-) -- 2.33.0
