Re: 32bit x86 build broken (was: Re: [GIT PULL] Networking for 5.16-rc1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/12/2021 4:04 PM, Srinivas Pandruvada wrote:
On Fri, 2021-11-12 at 06:33 -0800, Jakub Kicinski wrote:
On Thu, 11 Nov 2021 18:48:43 -0800 Linus Torvalds wrote:
On Thu, Nov 11, 2021 at 5:46 PM Jakub Kicinski <kuba@xxxxxxxxxx>
wrote:
Rafael, Srinivas, we're getting 32 bit build failures after pulling
back
from Linus today.

make[1]: *** [/home/nipa/net/Makefile:1850: drivers] Error 2
make: *** [Makefile:219: __sub-make] Error 2
../drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:
In function ‘send_mbox_cmd’:
../drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:7
9:37: error: implicit declaration of function ‘readq’; did you mean
‘readl’? [-Werror=implicit-function-declaration]
    79 |                         *cmd_resp = readq((void __iomem *)
(proc_priv->mmio_base + MBOX_OFFSET_DATA));
       |                                     ^~~~~
       |                                     readl
Gaah.

The trivial fix is *probably* just a simple
To be sure - are you planning to wait for the fix to come via
the usual path?  We can hold applying new patches to net on the
off chance that you'd apply the fix directly and we can fast
forward again :)

Not that 32bit x86 matters all that much in practice, it's just
for preventing new errors (64b divs, mostly) from sneaking in.

I'm guessing Rafeal may be AFK for the independence day weekend.
He was off, but not sure if he is back. I requested Daniel to send PULL
request for
https://lore.kernel.org/lkml/a22a1eeb-c7a0-74c1-46e2-0a7bada73520@xxxxxxxxxxxxx/T/



Sorry for the delay, I'd been offline for the last few days.

I'm back now and I will be picking up the Arnd's patch shortly even though the simple fix is already there.





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux