Only one of the macros (`__packed`) is used and the raw attribute is used elsewhere in the code-base. Signed-off-by: Jeremy Sowden <jeremy@xxxxxxxxxx> --- include/ulogd/ulogd.h | 5 ----- output/ipfix/ipfix.c | 2 -- output/ipfix/ipfix.h | 8 ++++---- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/include/ulogd/ulogd.h b/include/ulogd/ulogd.h index 09f4a09cc56e..3956f5f656ec 100644 --- a/include/ulogd/ulogd.h +++ b/include/ulogd/ulogd.h @@ -28,11 +28,6 @@ /* types without length */ #define ULOGD_RET_NONE 0x0000 -#define __packed __attribute__((packed)) -#define __noreturn __attribute__((noreturn)) -#define __cold __attribute__((cold)) - -#define __packed __attribute__((packed)) #define ULOGD_RET_INT8 0x0001 #define ULOGD_RET_INT16 0x0002 diff --git a/output/ipfix/ipfix.c b/output/ipfix/ipfix.c index b2719fd1d8a3..e0b3440e1d1a 100644 --- a/output/ipfix/ipfix.c +++ b/output/ipfix/ipfix.c @@ -8,8 +8,6 @@ /* These forward declarations are needed since ulogd.h doesn't like to be the first */ #include <ulogd/linuxlist.h> -#define __packed __attribute__((packed)) - #include "ipfix.h" #include <ulogd/ulogd.h> diff --git a/output/ipfix/ipfix.h b/output/ipfix/ipfix.h index 93945fbd562b..b0f3ae64740f 100644 --- a/output/ipfix/ipfix.h +++ b/output/ipfix/ipfix.h @@ -19,7 +19,7 @@ struct ipfix_hdr { uint32_t seqno; uint32_t oid; /* Observation Domain ID */ uint8_t data[]; -} __packed; +} __attribute__((packed)); #define IPFIX_HDRLEN sizeof(struct ipfix_hdr) @@ -32,7 +32,7 @@ struct ipfix_templ_hdr { uint16_t tid; uint16_t cnt; uint8_t data[]; -} __packed; +} __attribute__((packed)); #define IPFIX_TEMPL_HDRLEN(nfields) sizeof(struct ipfix_templ_hdr) + (sizeof(uint16_t) * 2 * nfields) @@ -42,7 +42,7 @@ struct ipfix_set_hdr { uint16_t id; uint16_t len; uint8_t data[]; -} __packed; +} __attribute__((packed)); #define IPFIX_SET_HDRLEN sizeof(struct ipfix_set_hdr) @@ -67,7 +67,7 @@ struct vy_ipfix_data { uint16_t dport; uint8_t l4_proto; uint32_t aid; /* Application ID */ -} __packed; +} __attribute__((packed)); #define VY_IPFIX_SID 256 -- 2.33.0