Re: [PATCH nft] tests: shell: $NFT needs to be invoked unquoted

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 21, 2021 at 07:54:38PM +0200, Štěpán Němec wrote:
> The variable has to undergo word splitting, otherwise the shell tries
> to find the variable value as an executable, which breaks in cases that
> 7c8a44b25c22 ("tests: shell: Allow wrappers to be passed as nft command")
> intends to support.
> 
> Mention this in the shell tests README.
> 
> Fixes: d8ccad2a2b73 ("tests: cover baecd1cf2685 ("segtree: Fix segfault when restoring a huge interval set")")
> Signed-off-by: Štěpán Němec <snemec@xxxxxxxxxx>
> ---
> The test I added (0068) is the only problematic occurrence.
> 
> This would be best applied on top of the README series (otherwise
> the README still talks about $NFT being a path to a binary).

OK, then I'll mark this one as "Changed Requested" and will wait for
you to include this one in the v2 of you README series.

Thanks.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux