Re: [PATCH nft] tests: cover baecd1cf2685 ("segtree: Fix segfault when restoring a huge interval set")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stepan,

On Wed, Oct 20, 2021 at 02:42:20PM +0200, Štěpán Němec wrote:
> Test inspired by [1] with both the set and stack size reduced by the
> same power of 2, to preserve the (pre-baecd1cf2685) segfault on one
> hand, and make the test successfully complete (post-baecd1cf2685) in a
> few seconds even on weaker hardware on the other.
> 
> (The reason I stopped at 128kB stack size is that with 64kB I was
> getting segfaults even with baecd1cf2685 applied.)
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1908127
> 
> Signed-off-by: Štěpán Němec <snemec@xxxxxxxxxx>
> Helped-by: Phil Sutter <phil@xxxxxx>

Thanks for the patch, just one remark:

[...]
> +cat >>"$ruleset_file" <<\EOF
                          ~~~
Is this backslash a typo or intentional?

Cheers, Phil



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux