Re: Suspicious pattern for use of function xt_register_template()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote:
> Dear Florian, dear netfilter maintainers,
> Commit fdacd57c79b ("netfilter: x_tables: never register tables by
> default") on linux-next
> introduces the function xt_register_template() and in all cases but
> one, the calls to that function are followed by:
>     if (ret < 0)
>         return ret;
> All these checks were also added with the commit above.
> In the one case, for iptable_mangle_init() in
> ./net/ipv4/netfilter/iptable_mangle.c, this pattern was not followed.

Thats a bug, the error test is missing.

[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux