Re: [PATCH libnetfilter_queue v3 1/3] build: doc: Fix NAME entry in man pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Jeremy,

On Sat, Aug 21, 2021 at 10:55:28AM +0100, Jeremy Sowden wrote:
> On 2021-08-21, at 15:38:03 +1000, Duncan Roe wrote:
> > Add a post_process() function to the big shell script inside doxygen/
> Would it not make life easier to move all this shell-script into a
> and just call that from the make-file?  Patch attached.
> J.

Of course it would, and that's how it was at library release 1.0.5, but `make
distcheck` would not pass, as it doesn't pass with your patch as supplied.

Your patch inspired me to try one last time and, thanks to hours of grovelling
through `info autoconf`, `make distcheck` passes with the 1-line patch below.

Remarkably, the resulting tarball includes doxygen/ even though
there is no EXTRA_DIST entry for it in

VPATH builds still work (e.g. mkdir build; cd build; ../configure; make) and
`make distcleancheck` still passes afterward.

So, I'll push out another patch rev shortly. Thanks!

Cheers ... Duncan.
>From a1795e7f1baff2d477d0a0a7e3058343baf3d85e Mon Sep 17 00:00:00 2001
From: Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx>
Date: Sun, 22 Aug 2021 11:19:22 +1000
Subject: [PATCH libnetfilter_queue] Replace ./ with

Signed-off-by: Duncan Roe <duncan_roe@xxxxxxxxxxxxxxx>
 doxygen/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doxygen/ b/doxygen/
index 52dca07..aa19c5a 100644
--- a/doxygen/
+++ b/doxygen/
@@ -25,7 +25,7 @@ doxyfile.stamp: $(doc_srcs)
 # but not blank lines
-	./
+	$(abs_top_srcdir)/doxygen/
 	touch doxyfile.stamp

[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux