On Wed, Aug 11, 2021 at 11:02:03AM +0200, Pablo Neira Ayuso wrote: > On Wed, Aug 11, 2021 at 04:21:40PM +1000, Duncan Roe wrote: > [...] > > Suggest you leave include/libnetfilter_queue/libnetfilter_queue.h unaltered. > > > > That way, if a user fails to insert linux/netfilter/nfnetlink_queue.h at all, he > > will get the warning. With the patched libnetfilter_queue.h, he will get > > compilation errors where previously he did not. > > OK, done and pushed it out. Thanks. You really didn't need all these extra #include lines. The only source that doesn't compile with "#include <libnetfilter_queue/linux_nfnetlink_queue.h>" removed from libnetfilter_queue.h is libnetfilter_queue.c. So, only src/libnetfilter_queue.c needed "#include <linux/netfilter/nfnetlink_queue.h>". If in the future any of the others were changed so nfnetlink_queue.h *was* required, the person doing the change would get the warning and insert the #include then. Worth a v2? Cheers ... Duncan.
