Re: [PATCH nftables] evaluate: add set to cache once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 14, 2021 at 02:24:54PM +0200, Pablo Neira Ayuso wrote:
> 67d3969a7244 ("evaluate: add set to the cache") re-adds the set into the
> cache again.
> 
> This bug was hidden behind 5ec5c706d993 ("cache: add hashtable cache for
> table") which broken set_evaluate() for anonymous sets.
> 
> Phil reported a gcc compilation warning which uncovered this problem.
> 
> Reported-by: Phil Sutter <phil@xxxxxx>
> Fixes: 67d3969a7244 ("evaluate: add set to the cache")
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Thanks for the quick fix!

Out of curiosity, did you not use set_is_anonymous() in commit
bbcc5eda7e588 on purpose?

Cheers, Phil



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux