Re: [PATCH nf-next] nfilter: nf_hooks: fix build failure with NF_TABLES=n

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> On Tue, Jun 08, 2021 at 05:53:26PM +0200, Florian Westphal wrote:
> > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > > Maybe from Kconfig, select CONFIG_NF_TABLES from NFNETLINK_HOOK to
> > > reduce ifdef pollution?
> > 
> > Why? It doesn't depend on nftables?
> 
> From kernelside, yes. But you have to compile userspace nftables to
> use this infra, unless there is separated tooling, userspace library
> or you code your own netlink userspace code.
> 
> Adding the "depends on" might also help signal distros that this
> subsystem is useful to be turned on.
> 
> The #ifdef is perfectly fine to fix the kbuild robot issue, I was just
> thinking if it is probably better a different path when looking at the
> whole picture.

Fair enough, please discard this, I will send the depends-on patch then.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux