On 19.05.2021 14:23, Florian Westphal wrote: > > Hi Florian, I tested your patch and it solved the issue, no more NFS > > hangs due to dropped RSTs. Please include it, together with the > > following two patches I previously sent: > > > > https://patchwork.ozlabs.org/project/netfilter-devel/patch/20210428130911.cteglt52r5if7ynp@Fryzen495/ > > Do we still need this one after this revised patch? > If we do, the help text has to be fixed, after your patch, be-liberal > turns off all sequence number/window checks. The revised text implies > it only has to do with RSTs. > > Alternative would be to add another sysctl, or turn the existing sysctl > into integer (0, off, 1 current behaviour (sequence check on for rst > only, 2 off for everything). I would still like to make the RST sequence number check optional. I think it is a good idea to use 0, 1 and > 1 off for everything, keeping this way the current behaviour when tcp_be_liberal is set to 1. I will send another patch with also revised text. Many thanks. Ali
