Re: [PATCH nf-next 02/12] netfilter: x_tables: remove ipt_unregister_table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Florian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on nf-next/master]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-remove-xtables-pointers-from-struct-net/20210420-202627
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-randconfig-a006-20210420 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ca8eef7e3da8f750d7c7aa004fe426d1d34787ea)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/8851cbce76d6751ac25fc0a7971f5fdea96e3d6f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Florian-Westphal/netfilter-remove-xtables-pointers-from-struct-net/20210420-202627
        git checkout 8851cbce76d6751ac25fc0a7971f5fdea96e3d6f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> net/ipv4/netfilter/ip_tables.c:1773:6: warning: no previous prototype for function 'ipt_unregister_table' [-Wmissing-prototypes]
   void ipt_unregister_table(struct net *net, struct xt_table *table)
        ^
   net/ipv4/netfilter/ip_tables.c:1773:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void ipt_unregister_table(struct net *net, struct xt_table *table)
   ^
   static 
   1 warning generated.


vim +/ipt_unregister_table +1773 net/ipv4/netfilter/ip_tables.c

  1772	
> 1773	void ipt_unregister_table(struct net *net, struct xt_table *table)
  1774	{
  1775		__ipt_unregister_table(net, table);
  1776	}
  1777	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux