Re: [PATCH libnetfilter_queue 1/1] build: doc: `make distcheck` passes with doxygen enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 2021-04-20 06:23, Duncan Roe wrote:
>-AS_IF([test "x$with_doxygen" = xyes], [
>+	    [create doxygen documentation])],
>+	    [with_doxygen="$withval"], [with_doxygen=yes])
>+
>+AS_IF([test "x$with_doxygen" != xno], [
> 	AC_CHECK_PROGS([DOXYGEN], [doxygen])
> 	AC_CHECK_PROGS([DOT], [dot], [""])
> 	AS_IF([test "x$DOT" != "x"],
>@@ -48,6 +49,10 @@ AS_IF([test "x$with_doxygen" = xyes], [
> ])
> 
> AM_CONDITIONAL([HAVE_DOXYGEN], [test -n "$DOXYGEN"])
>+if test -z "$DOXYGEN"; then

If you use AS_IF above, you could also make use of it here :)

>+# move it out of the way and symlink the real one while we run doxygen.
>+	cd ..; [ $$(ls src | wc -l) -gt 8 ] ||\

This looks like it could break anytime (say, when it happens to get to 9
files). Can't it test for a specific filename or set of names?

>+       function main { set -e; cd man/man3; rm -f _*;\

The syntax for POSIX sh-compatible functions should be

	main() { ...

>+function setgroup { mv $$1.3 $$2.3; BASE=$$2; };\
>+function add2group { for i in $$@; do ln -sf $$BASE.3 $$i.3; done; };\

Should be quoted, i.e. "$$@". Might as well do it for the other vars.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux