[PATCH v2 2/2] ebtables: Spewing an error if --concurrent isn't first argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Our customer reported a following issue:
If '--concurrent' was passed to ebtables command behind other arguments,
'--concurrent' will not take effect sometimes; for a simple example,
ebtables -L --concurrent. This is becuase the handling of '--concurrent'
is implemented in a passing-order-dependent way.

Fixed this problem as Pablo Neira Ayuso suggested by simply spewing
an error like following:
./ebtables-legacy -L --concurrent
Please put the --concurrent option first.

Signed-off-by: Firo Yang <firo.yang@xxxxxxxx>
---
 ebtables.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ebtables.c b/ebtables.c
index f7dfccf..c1f5c2b 100644
--- a/ebtables.c
+++ b/ebtables.c
@@ -1041,6 +1041,8 @@ big_iface_length:
 			strcpy(replace->filename, optarg);
 			break;
 		case 13 : /* concurrent */
+			if (OPT_COMMANDS)
+				ebt_print_error2("Please put the --concurrent option first");
 			use_lockfd = 1;
 			break;
 		case 1 :
-- 
2.30.2





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux