Hi Pablo, I love your patch! Perhaps something to improve: [auto build test WARNING on nf-next/master] url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nft_payload-fix-C-VLAN-offload-support/20210412-211319 base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/09978fe09a0a0b8a4dcdd065502b6bd73f1d3e5d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-nft_payload-fix-C-VLAN-offload-support/20210412-211319 git checkout 09978fe09a0a0b8a4dcdd065502b6bd73f1d3e5d # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> net/netfilter/nf_tables_offload.c:55:6: warning: no previous prototype for 'nft_flow_rule_transfer_vlan' [-Wmissing-prototypes] 55 | void nft_flow_rule_transfer_vlan(struct nft_offload_ctx *ctx, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/nft_flow_rule_transfer_vlan +55 net/netfilter/nf_tables_offload.c 54 > 55 void nft_flow_rule_transfer_vlan(struct nft_offload_ctx *ctx, 56 struct nft_flow_rule *flow) 57 { 58 struct nft_flow_match *match = &flow->match; 59 struct nft_offload_ethertype ethertype = { 60 .value = match->key.basic.n_proto, 61 .mask = match->mask.basic.n_proto, 62 }; 63 64 if ((flow->match.dissector.used_keys & 65 (BIT(FLOW_DISSECTOR_KEY_VLAN) | BIT(FLOW_DISSECTOR_KEY_CVLAN))) == 66 (BIT(FLOW_DISSECTOR_KEY_VLAN) | BIT(FLOW_DISSECTOR_KEY_CVLAN))) { 67 match->key.basic.n_proto = match->key.cvlan.vlan_tpid; 68 match->mask.basic.n_proto = match->mask.cvlan.vlan_tpid; 69 match->key.cvlan.vlan_tpid = match->key.vlan.vlan_tpid; 70 match->mask.cvlan.vlan_tpid = match->mask.vlan.vlan_tpid; 71 match->key.vlan.vlan_tpid = ethertype.value; 72 match->mask.vlan.vlan_tpid = ethertype.mask; 73 } else if (flow->match.dissector.used_keys & (BIT(FLOW_DISSECTOR_KEY_VLAN))) { 74 match->key.basic.n_proto = match->key.vlan.vlan_tpid; 75 match->mask.basic.n_proto = match->mask.vlan.vlan_tpid; 76 match->key.vlan.vlan_tpid = ethertype.value; 77 match->mask.vlan.vlan_tpid = ethertype.mask; 78 } else if (match->key.basic.n_proto == htons(ETH_P_8021Q) || 79 match->key.basic.n_proto == htons(ETH_P_8021AD)) { 80 match->key.vlan.vlan_tpid = ethertype.value; 81 match->mask.vlan.vlan_tpid = ethertype.mask; 82 match->dissector.used_keys |= BIT(FLOW_DISSECTOR_KEY_VLAN); 83 match->key.basic.n_proto = 0; 84 match->mask.basic.n_proto = 0; 85 match->dissector.used_keys &= ~BIT(FLOW_DISSECTOR_KEY_BASIC); 86 } 87 } 88 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
