Re: [PATCH netfilter] netfilter: xt_IDLETIMER: fix idletimer_tg_helper non-kosher casts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > The code is relying on the identical layout of the beginning
> > of the v0 and v1 structs, but this can easily lead to code bugs
> > if one were to try to extend this further...
>
> What is the concern?  These structs are part of ABI, they
> cannot be changed.

That is a reasonable point, but there should have at *least* been
a solid comment about why this sort of cast is safe.



[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux