list_first_entry() returns garbage when the list is empty.
There is no need to run the following loop if we have no statements,
so just return 0.
Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
---
src/evaluate.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/evaluate.c b/src/evaluate.c
index 0b251ab5554c..2ddbde0a370f 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -1363,10 +1363,12 @@ static int __expr_evaluate_set_elem(struct eval_ctx *ctx, struct expr *elem)
"number of statements mismatch, set expects %d "
"but element has %d", num_set_exprs,
num_elem_exprs);
- } else if (num_set_exprs == 0 && !(set->flags & NFT_SET_EVAL)) {
- return expr_error(ctx->msgs, elem,
- "missing statements in %s definition",
- set_is_map(set->flags) ? "map" : "set");
+ } else if (num_set_exprs == 0) {
+ if (!(set->flags & NFT_SET_EVAL))
+ return expr_error(ctx->msgs, elem,
+ "missing statements in %s definition",
+ set_is_map(set->flags) ? "map" : "set");
+ return 0;
}
set_stmt = list_first_entry(&set->stmt_list, struct stmt, list);
--
2.26.2
